[18.0][MIG] web_timeline by JasminSForgeFlow · Pull Request #3136 · OCA/web

JasminSForgeFlow · 2025-03-28T07:44:15Z

Standard Migration

Depends on:

[IMP] web_widget_dropdown_dynamic: Remove QUnit import from tests #3145 For tests

@ForgeFlow

carlos-lopez-tecnativa

Tested locally with OCA/project#1478.
Please check the CI or reference the PR to solve the issue in the test.

TT56064

web_timeline/static/src/views/timeline/timeline_controller.esm.js

carlos-lopez-tecnativa · 2025-04-17T16:50:51Z

web_timeline/tests/test_web_timeline.py

+class TestWebTimeline(HttpCase):
+    def test_timeline_arch(self):
+        self.browser_js(
+            "/web/tests/legacy?mod=web&filter=TimelineView - ArchParser",


Is it complicated to convert the tests to the new style?

not sure about it need to take a look

carlos-lopez-tecnativa · 2025-04-17T16:51:00Z

web_timeline/tests/test_web_timeline.py

+
+    def test_timeline_view(self):
+        self.browser_js(
+            "/web/tests/legacy?mod=web&filter=TimelineView - View",


the same here

pedrobaeza · 2025-04-17T17:15:36Z

/ocabot migration web_timeline

pedrobaeza · 2025-05-09T06:32:49Z

@JasminSForgeFlow any news?

* Avoid to display all items of group_by model * Remove unnecessary readgroup * Remove dependency on project. Modify module structure. Imporve readme file. * Add setup.py

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

* Update the vis.js framework to latest stable version (v4.20.1) to add new functionality and save almost 400ko of source code in odoo assets (the vis dev team has isolate the code for timeline widget from the rest of their widgets) * Add the possibility to display events with no duration (instantaneous) as the same time has regular events * Add the possibility to choose between two scroll mode : - zoom in time resolution (default) or - vertical scroll (web browser default behaviour) Signed-off-by: adrien.didenot <adrien.didenot@horanet.com>

…same as base Calendar view) In Odoo calendar view, the attribute date_delay is an alternative to date_stop, to provides the duration of the event instead of its end date. This commit integrate this attribute to the Timeline view, but contrary to the base Calendar view the Timeline view could use both arguments (date_stop and date_delay) simultaneously. Signed-off-by: adrien.didenot <adrien.didenot@horanet.com>

The default window display all the events (aka 'fit'), in case of events spread over the year, the events are invisibles (too small to be readable) Signed-off-by: adrien.didenot <adrien.didenot@horanet.com>

Change the attribute 'default_window' to 'mode' like the Odoo calendar view (to be iso functional)

- Convert Moment.js to Luxon. - Replace Underscore.js with native JavaScript code. - Migrate legacy views to the new system and add an architecture parser to separate logic. - added basic test

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-17.0/web-17.0-web_timeline Translate-URL: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_timeline/

Currently translated at 100.0% (16 of 16 strings) Translation: web-17.0/web-17.0-web_timeline Translate-URL: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_timeline/it/

pedrobaeza · 2025-05-09T06:46:07Z

CI is still red.

JasminSForgeFlow · 2025-05-09T06:49:18Z

CI is still red.

It's because of this warning

2025-05-09 06:39:17,536 287 WARNING odoo odoo.addons.web_timeline.tests.test_web_timeline.TestWebTimeline.test_timeline_view.browser: You disabled XSS protection for vis-Timeline. I sure hope you know what you're doing!

which is deactivated e3e9b5d

pedrobaeza · 2025-05-09T06:51:55Z

@carlos-lopez-tecnativa do you know if this disabling is still needed? We should find any way of avoiding the red CI, silencing the warning or removing it at all.

carlos-lopez-tecnativa · 2025-05-09T13:20:03Z

@JasminSForgeFlow please include #3169 to test that the XSS issue is resolved.

…L rendering Before this commit, XSS filtering was disabled, which could introduce potential security risks. This commit adopts a safer approach, similar to PR OCA#2525. After this commit, XSS filtering is re-enabled, and a whitelist of allowed HTML elements is provided.

JasminSForgeFlow · 2025-05-13T03:40:11Z

@JasminSForgeFlow please include #3169 to test that the XSS issue is resolved.

Done, Thanks

carlos-lopez-tecnativa · 2025-05-13T11:02:58Z

Please include #3171

…endering

JasminSForgeFlow · 2025-05-13T11:31:21Z

Please include #3171

Added

carlos-lopez-tecnativa

LGTM @CarlosRoca13 @pedrobaeza please review this

CarlosRoca13

/ocabot merge nobump

OCA-git-bot · 2025-05-13T14:35:51Z

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-3136-by-CarlosRoca13-bump-nobump, awaiting test results.

OCA-git-bot · 2025-05-13T14:39:14Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2025-05-13T14:43:39Z

Congratulations, your PR was merged at 85adaab. Thanks a lot for contributing to OCA. ❤️

JasminSForgeFlow force-pushed the 18.0-mig-web_timeline branch 8 times, most recently from 51fa466 to ed5ccdf Compare April 1, 2025 07:12

JasminSForgeFlow mentioned this pull request Apr 1, 2025

[IMP] web_widget_dropdown_dynamic: Remove QUnit import from tests #3145

Merged

JasminSForgeFlow force-pushed the 18.0-mig-web_timeline branch from ed5ccdf to 718eca2 Compare April 1, 2025 09:49

carlos-lopez-tecnativa mentioned this pull request Apr 17, 2025

[18.0][MIG] project_timeline: Migration to version 18.0 OCA/project#1478

Merged

1 task

carlos-lopez-tecnativa suggested changes Apr 17, 2025

View reviewed changes

OCA-git-bot added this to the 18.0 milestone Apr 17, 2025

OCA-git-bot mentioned this pull request Apr 17, 2025

Migration to version 18.0 #2945

Open

46 tasks

JasminSForgeFlow force-pushed the 18.0-mig-web_timeline branch 4 times, most recently from d84aced to cf61ce8 Compare April 21, 2025 08:34

lmignon and others added 10 commits May 9, 2025 12:04

[IMP] web_timeline: Extracted from incubator

70dcb19

[IMP] web_timeline: Several improvements:

93b65d7

* Avoid to display all items of group_by model * Remove unnecessary readgroup * Remove dependency on project. Modify module structure. Imporve readme file. * Add setup.py

[IMP] web_timeline: add few features

4355da1

[MIG] web_timeline: Migration to 9.0

35a52ae

[FIX] web_timeline: fix commas in manifest file

4f20469

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

c07591a

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

[IMP] Add an option to initialize the timeline window on display.

9ab0434

The default window display all the events (aka 'fit'), in case of events spread over the year, the events are invisibles (too small to be readable) Signed-off-by: adrien.didenot <adrien.didenot@horanet.com>

[IMP] change the option to initialize the timeline window on display.

5bfae46

Change the attribute 'default_window' to 'mode' like the Odoo calendar view (to be iso functional)

carlos-lopez-tecnativa and others added 9 commits May 9, 2025 12:04

[MIG] web_timeline: Migration to 17.0

c76ee94

- Convert Moment.js to Luxon. - Replace Underscore.js with native JavaScript code. - Migrate legacy views to the new system and add an architecture parser to separate logic. - added basic test

[UPD] Update web_timeline.pot

908fbfd

[BOT] post-merge updates

a54e20f

Update translation files

22a5d4d

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-17.0/web-17.0-web_timeline Translate-URL: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_timeline/

Translated using Weblate (Italian)

d16f7bd

Currently translated at 100.0% (16 of 16 strings) Translation: web-17.0/web-17.0-web_timeline Translate-URL: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_timeline/it/

[IMP] web_timeline: Update vis-timeline-graph2d lib: 7.7.0 -> 7.7.3

dac102c

[BOT] post-merge updates

a3a289c

[IMP] web_timeline: black, isort, prettier

53f2b27

[MIG] web_timeline: Migration to 18.0

258a5a9

JasminSForgeFlow force-pushed the 18.0-mig-web_timeline branch from cf61ce8 to 258a5a9 Compare May 9, 2025 06:36

[FIX] web_timeline: Add <b> element to XSS whitelist for safer HTML r…

4620f02

…endering

carlos-lopez-tecnativa approved these changes May 13, 2025

View reviewed changes

CarlosRoca13 approved these changes May 13, 2025

View reviewed changes

OCA-git-bot added the approved label May 13, 2025

OCA-git-bot added bot is merging ⏳ ready to merge labels May 13, 2025

OCA-git-bot merged commit 107e415 into OCA:18.0 May 13, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 13, 2025

Uh oh!

Conversation

JasminSForgeFlow commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

carlos-lopez-tecnativa Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

JasminSForgeFlow Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

carlos-lopez-tecnativa Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Apr 17, 2025

Uh oh!

pedrobaeza commented May 9, 2025

Uh oh!

pedrobaeza commented May 9, 2025

Uh oh!

JasminSForgeFlow commented May 9, 2025

Uh oh!

pedrobaeza commented May 9, 2025

Uh oh!

carlos-lopez-tecnativa commented May 9, 2025

Uh oh!

JasminSForgeFlow commented May 13, 2025

Uh oh!

carlos-lopez-tecnativa commented May 13, 2025

Uh oh!

JasminSForgeFlow commented May 13, 2025

Uh oh!

carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

Uh oh!

CarlosRoca13 left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented May 13, 2025

Uh oh!

OCA-git-bot commented May 13, 2025

Uh oh!

Uh oh!

OCA-git-bot commented May 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

JasminSForgeFlow commented Mar 28, 2025 •

edited

Loading